Upgrade to NHS.UK frontend v10.3 #323
Conversation
colinrotherham
force-pushed
the
nhsuk-frontend-v10.3
branch
from
b5a442f to
ba70e15
Compare
colinrotherham
force-pushed
the
nhsuk-frontend-v10.3
branch
from
ba70e15 to
fac75a6
Compare
|
Not sure if you'd be up for reviewing this please @mikeathan-nhs? I could do with adding some extra bits to the migration guide but the component changes are ready to review |
colinrotherham
force-pushed
the
nhsuk-frontend-v10.3
branch
from
fac75a6 to
8b64fbb
Compare
|
Hi yes i can do. we have sprint ceremonies today so when i get a chance will go through the changes, Thanks |
| data-checkbox-exclusive-group={name} | ||
| checked={checked} | ||
| defaultChecked={defaultChecked} | ||
| data-checkbox-exclusive-group={name} |
There was a problem hiding this comment.
i think data-checkbox-exclusive-group should be set only if exclusive prop is set too ?
| {visuallyHiddenText ? ( | ||
| <> | ||
| <span className="nhsuk-u-visually-hidden">{`${visuallyHiddenText}:`}</span> {children} | ||
| <span className="nhsuk-u-visually-hidden"> |
There was a problem hiding this comment.
although is not present in the service manual, in the Changelog they mention swap the <span class="nhsuk-error-message"> for a <p class="nhsuk-error-message">
There was a problem hiding this comment.
Well spotted, thank you
| return ( | ||
| <search className="nhsuk-header__search"> | ||
| <form className="nhsuk-header__search-form" id={id} action={action} method={method} {...rest}> | ||
| <label className="nhsuk-u-visually-hidden" htmlFor="search-field"> |
There was a problem hiding this comment.
The search header in latest version has these two divs nhsuk-form-group and nhsuk-input wrapper inside search-form.
2 participants
This PR upgrades the React components to NHS.UK frontend v10.3
The file upload component, card actions and interruption panel variant are all included